NEC-114: e2e flake: folder-menu 'Show members…' item not displayed within 5 s in commands.test.ts #207

Merged
nectenda-agent merged 2 commits from worktree-nec-114-e2e-flake-folder-menu-show-members-item into main 2026-09-29 00:46:55 +01:00
Collaborator

Task: NEC-114 — https://projectron.nerchure.com/tasks/114

Instruments the flaky People… wait in commands.test.ts (FLAKE-5). On timeout it now fails with the page: every menu and its titles, focus, backdrops, the element under the folder title, and whether the right-click's contextmenu event arrived and was cancelled. No fix and no retry. The suspected cause (a menu raised after another closed never attaching) was tested before fixing and did not reproduce: 0 misses in 2,700 targeted right-clicks across macOS and the CI runner, and 18 of 18 whole-suite passes. On the user's decision, only the instrumentation ships; the temporary repro is not merged. The numbers are in the spec and FLAKE-5.

Spec: docs/changes/NEC-114-folder-menu-people-flake/spec.md

Changelog

NONE

Task: NEC-114 — https://projectron.nerchure.com/tasks/114 Instruments the flaky People… wait in commands.test.ts (FLAKE-5). On timeout it now fails with the page: every menu and its titles, focus, backdrops, the element under the folder title, and whether the right-click's contextmenu event arrived and was cancelled. No fix and no retry. The suspected cause (a menu raised after another closed never attaching) was tested before fixing and did not reproduce: 0 misses in 2,700 targeted right-clicks across macOS and the CI runner, and 18 of 18 whole-suite passes. On the user's decision, only the instrumentation ships; the temporary repro is not merged. The numbers are in the spec and FLAKE-5. Spec: `docs/changes/NEC-114-folder-menu-people-flake/spec.md` ## Changelog NONE
FLAKE-5: twice in a full local run, the People… item was not displayed
within 5 s of the real right-click, with an error that said nothing about
the page. The wait now fails with every .menu and its titles, focus,
backdrops, what sits under the folder title, and where the right-click
landed. No retry: it would hide which cause it was.

No fix: the suspected cause (a menu raised straight after another closed
never attaching) did not reproduce — 0 misses in 900 targeted right-clicks
per sequence across macOS and the CI runner, and 18 of 18 whole-suite
passes. The numbers are in the spec and in FLAKE-5.

Task: NEC-114

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BAyTmBMAqj7RoCFBqLzX2n
Record the right-click as it ends, and drop a field that could not vary
All checks were successful
Release note / release-note (pull_request) Successful in 14s
CI / build (pull_request) Successful in 5m37s
CI / e2e (pull_request) Successful in 6m1s
CI / promote (pull_request) Has been skipped
414f345f62
A review found three things in the probe. An armed probe that saw no
event said "not armed", which read as a harness fault rather than the
answer: it now says fired: false. defaultPrevented was read in the capture
phase, before Obsidian's handlers ran, so it could only be false: it is now
read once dispatch ends, and does come back true for a real right-click.
And a menu's isConnected is always true for a node found by querySelectorAll,
so it is gone; a menu built and never attached shows as a fired right-click
with no menu. Class names are read with getAttribute, which SVG targets
answer too.

Task: NEC-114

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BAyTmBMAqj7RoCFBqLzX2n
cruelacid force-pushed worktree-nec-114-e2e-flake-folder-menu-show-members-item from 414f345f62
All checks were successful
Release note / release-note (pull_request) Successful in 14s
CI / build (pull_request) Successful in 5m37s
CI / e2e (pull_request) Successful in 6m1s
CI / promote (pull_request) Has been skipped
to 1552d05349
All checks were successful
Release note / release-note (pull_request) Successful in 12s
CI / build (pull_request) Successful in 4m48s
CI / e2e (pull_request) Successful in 5m24s
CI / promote (pull_request) Has been skipped
CI / build (push) Successful in 5m6s
CI / e2e (push) Successful in 5m20s
CI / promote (push) Successful in 30s
2026-09-29 00:40:54 +01:00
Compare
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Nectenda/nectenda!207
No description provided.