NEC-130: Editors cannot see collaborators' key fingerprints #194

Merged

nectenda-agent merged 3 commits from worktree-nec-130-editors-cannot-see-collaborators-key-fin into main 2026-09-27 13:47:59 +01:00

Conversation 0 Commits 3 Files changed 10 +427 -80

nectenda-agent commented 2026-09-27 09:57:21 +01:00

Collaborator

Copy link

Task: NEC-130 — https://projectron.nerchure.com/tasks/130

The People dialog was offered only for folders this vault owns, so an editor could never see or compare a collaborator's key fingerprint. Comparing fingerprints is the defence against a server that substitutes keys (docs/security-model.md, CRYPTO-104), and it takes both people. Every member now reaches the dialog from the palette, the folder menu, the folder's settings page and the organisation's folder list. Editors see names, roles, fingerprints and Mark as compared; invite, role, remove, invitations and add-from-roster stay owner-only. The server already let any member list a folder's people, so only the plugin changes. Row logic moves to member-rows.ts with unit tests (mutation-checked both ways), and identity.test.ts gains an e2e step that opens the dialog as the editor vault and records a comparison.

Spec: docs/changes/NEC-130-editor-people-view/spec.md

Changelog

Editors can now open a shared folder's People list to see and compare everyone's key fingerprints and mark them as compared.

Task: NEC-130 — https://projectron.nerchure.com/tasks/130 The People dialog was offered only for folders this vault owns, so an editor could never see or compare a collaborator's key fingerprint. Comparing fingerprints is the defence against a server that substitutes keys (docs/security-model.md, CRYPTO-104), and it takes both people. Every member now reaches the dialog from the palette, the folder menu, the folder's settings page and the organisation's folder list. Editors see names, roles, fingerprints and Mark as compared; invite, role, remove, invitations and add-from-roster stay owner-only. The server already let any member list a folder's people, so only the plugin changes. Row logic moves to member-rows.ts with unit tests (mutation-checked both ways), and identity.test.ts gains an e2e step that opens the dialog as the editor vault and records a comparison. Spec: `docs/changes/NEC-130-editor-people-view/spec.md` ## Changelog Editors can now open a shared folder's People list to see and compare everyone's key fingerprints and mark them as compared.

nectenda-agent added the

area:plugin

label 2026-09-27 09:57:21 +01:00

nectenda-agent added 3 commits 2026-09-27 09:57:21 +01:00

Show editors a folder's people and fingerprints, read-only ... 96813fc7bd

The People dialog and every way into it were offered only for folders
this vault owns, so an editor could never see or compare a collaborator's
key fingerprint. Comparing is the defence against a server that swaps
keys, and it takes both people.

Every member now reaches the dialog from the palette, the folder menu,
the folder's settings page and the organisation's folder list. An editor
sees names, roles, fingerprints and "Mark as compared"; the invite row,
role dropdown, Remove, invitations and add-from-roster stay owner-only.
The row rule moves to member-rows.ts so it is tested without Obsidian.

Task: NEC-130

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01P25qBQE9kWrX9Eg5VALBMC

Give the editor's people step an owner key to compare ... 1adeb8940e

The seeded owner never enrols a key, so its row had no fingerprint and
no "Mark as compared". The step now gives the folder's owner a key on
the shard for its duration and restores the row afterwards. It waits for
the owner's row rather than the first description, which is the People
heading's and empty. It checks the comparison under the owner's address
and the fingerprint that was shown, and closes the dialog in a finally.

Task: NEC-130

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01P25qBQE9kWrX9Eg5VALBMC

Expect People… on an editor's folder row ... bc14585aa1

The unshare step asserted an editor's synced-folder row carries only
"Stop syncing here". It now also offers the read-only people list, so
the step expects it on this build and the old row on the last published
plugin. What it guards is unchanged: no way to end a folder that is not
the editor's to end.

Task: NEC-130

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01P25qBQE9kWrX9Eg5VALBMC

cruelacid force-pushed worktree-nec-130-editors-cannot-see-collaborators-key-fin from bc14585aa1 to 411ffd68ad 2026-09-27 11:08:22 +01:00 Compare

nectenda-agent merged commit 411ffd68ad into main 2026-09-27 13:47:59 +01:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

area:docs

docs/

  

area:identity

packages/identity

  

area:ops

deploy/, CI, hosting

  

area:plugin

packages/plugin

  

area:server

packages/server

  

channel:community

Obsidian forum, Obsidian Discord, Reddit

  

channel:direct

Cold outreach to named firms

  

channel:owned

nectenda.com pages, the feedback board

  

channel:press

Hacker News, newsletters, outlets, YouTube creators

  

channel:social

Bluesky, Mastodon, X, YouTube accounts

  

e2ee-constrained

End-to-end encryption changes the shape of the answer

  

gate:at-ga

Held until Gates A-C close and terms/privacy leave DRAFT

  

gate:pre-ga

Safe to do before the launch gates close

  

marketing

Reach and positioning; work published off nectenda.com

  

parity

Relay feature-parity programme

  

relay:absent

4 - Not supported, not requested, not planned at Relay

  

relay:planned

2 - On Relay's roadmap (Active/Planned) or has an open PR

  

relay:requested

3 - Asked for by Relay users or under 'Considering'; not committed

  

relay:supported

1 - Relay ships this today

  

risk:additive

New message type, table or column; backward compatible

  

risk:contract

Changes something existing accounts or stored data depend on

  

risk:none

Client-only; the server is untouched

  

usability

How the product is understood and learned, not what it does

No labels

area:docs

area:identity

area:ops

area:plugin

area:server

channel:community

channel:direct

channel:owned

channel:press

channel:social

e2ee-constrained

gate:at-ga

gate:pre-ga

marketing

parity

relay:absent

relay:planned

relay:requested

relay:supported

risk:additive

risk:contract

risk:none

usability

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

Nectenda/nectenda!194

No description provided.