Nectenda/nectenda
Watch
1
0
Fork
You've already forked nectenda
 0
Code Issues 1 Pull requests Projects 5 Releases Packages Wiki Activity Actions

NEC-116: changelog cut strips only a trailing (#N), so a two-PR entry publishes one #181

Merged
nectenda-agent merged 2 commits from worktree-nec-116-changelog-cut-strips-only-a-trailing-n-s into main 2026-09-26 07:57:48 +01:00
Conversation 0 Commits 2 Files changed 6 +179 -10
nectenda-agent commented 2026-09-26 07:45:50 +01:00
Collaborator
Copy link

Task: NEC-116 — https://projectron.nerchure.com/tasks/116

Changelog cut stripped only a trailing (#N), so an entry crediting two pull requests published the first number into the mirror's CHANGELOG.md, the GitHub release body and the site. cut now strips every (#N) and (#N, #M) anywhere on a line, keeping indentation and spacing, and drops a continuation line that held only a PR number. scanPublicText now refuses a parenthesised (#N) in anything published, so cut and the mirror both reject one the stripper misses; draft previews the ledger as cut will leave it so Unreleased's by-design numbers do not warn. The new rule found one already in the mirror: a comment in content-sync.ts citing a private issue, reworded. Tests in scripts/changelog.test.mjs; every rule mutation-checked.

Spec: docs/changes/NEC-116-changelog-pr-references/spec.md

Changelog

NONE

Task: NEC-116 — https://projectron.nerchure.com/tasks/116 Changelog cut stripped only a trailing (#N), so an entry crediting two pull requests published the first number into the mirror's CHANGELOG.md, the GitHub release body and the site. cut now strips every (#N) and (#N, #M) anywhere on a line, keeping indentation and spacing, and drops a continuation line that held only a PR number. scanPublicText now refuses a parenthesised (#N) in anything published, so cut and the mirror both reject one the stripper misses; draft previews the ledger as cut will leave it so Unreleased's by-design numbers do not warn. The new rule found one already in the mirror: a comment in content-sync.ts citing a private issue, reworded. Tests in scripts/changelog.test.mjs; every rule mutation-checked. Spec: `docs/changes/NEC-116-changelog-pr-references/spec.md` ## Changelog NONE
cutUnreleased removed a PR number only at the end of a line, so an entry
crediting two pull requests — "(#166) (#175)" — published the first. The
match now runs anywhere on the line, including "(#1, #2)", and leaves the
line spaced as if the number had never been written.

scanPublicText now reports a parenthesised "(#N)", so cut and the mirror
refuse one the stripper missed instead of publishing it as though it were a
deliberate citation. Parenthesised because a bare #333 is a colour. draft
previews the ledger as cut will leave it, so the number every Unreleased
entry carries by design is not a warning.

The new rule found one already in the mirror: a comment in content-sync.ts
citing a private issue. Reworded.

Task: NEC-116

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Hq2ZoBQaUJZbSCBfTgqyAb
Tighten PR-number stripping and the scan rule after review
All checks were successful
Release note / release-note (pull_request) Successful in 13s
Details
CI / build (pull_request) Successful in 4m37s
Details
CI / e2e (pull_request) Successful in 5m13s
Details
CI / promote (pull_request) Has been skipped
Details
eee6ee7868 
Review found three edges, none reachable from what draft writes but all
reachable by a hand edit in the review window:

- "(#1) Start" kept a leading space and "a (#1)(#2)" a trailing one. The
  stripper now keeps a line's indentation, drops the gap after a leading
  reference, and trims what a trailing one leaves.
- A wrapped entry whose last line held only "(#166)" became a blank line
  inside the list. cut now drops a line that held nothing but PR numbers.
- The scan rule refused "(#12-steps)", a Markdown link to a heading. The
  number must now end at a bracket, comma or space. A bracketed all-digit
  colour such as "(#333)" still cannot be told from a PR number and is
  refused; the spec says so rather than claiming otherwise.

Task: NEC-116

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Hq2ZoBQaUJZbSCBfTgqyAb
cruelacid force-pushed worktree-nec-116-changelog-cut-strips-only-a-trailing-n-s from eee6ee7868
All checks were successful
Release note / release-note (pull_request) Successful in 13s
Details
CI / build (pull_request) Successful in 4m37s
Details
CI / e2e (pull_request) Successful in 5m13s
Details
CI / promote (pull_request) Has been skipped
Details
to 8f31add08a
All checks were successful
Release note / release-note (pull_request) Successful in 16s
Details
e2e / multi (push) Successful in 4m37s
Details
CI / build (pull_request) Successful in 4m47s
Details
CI / e2e (pull_request) Successful in 5m26s
Details
CI / promote (pull_request) Has been skipped
Details
Deploy site / deploy (push) Successful in 48s
Details
CI / build (push) Successful in 4m53s
Details
CI / e2e (push) Successful in 5m16s
Details
CI / promote (push) Successful in 31s
Details
2026-09-26 07:51:48 +01:00 Compare
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
area:docs
docs/

  
area:identity
packages/identity

  
area:ops
deploy/, CI, hosting

  
area:plugin
packages/plugin

  
area:server
packages/server

  
channel:community
Obsidian forum, Obsidian Discord, Reddit

  
channel:direct
Cold outreach to named firms

  
channel:owned
nectenda.com pages, the feedback board

  
channel:press
Hacker News, newsletters, outlets, YouTube creators

  
channel:social
Bluesky, Mastodon, X, YouTube accounts

  
e2ee-constrained
End-to-end encryption changes the shape of the answer

  
gate:at-ga
Held until Gates A-C close and terms/privacy leave DRAFT

  
gate:pre-ga
Safe to do before the launch gates close

  
marketing
Reach and positioning; work published off nectenda.com

  
parity
Relay feature-parity programme

  
relay:absent
4 - Not supported, not requested, not planned at Relay

  
relay:planned
2 - On Relay's roadmap (Active/Planned) or has an open PR

  
relay:requested
3 - Asked for by Relay users or under 'Considering'; not committed

  
relay:supported
1 - Relay ships this today

  
risk:additive
New message type, table or column; backward compatible

  
risk:contract
Changes something existing accounts or stored data depend on

  
risk:none
Client-only; the server is untouched

  
usability
How the product is understood and learned, not what it does

No labels
area:docs
area:identity
area:ops
area:plugin
area:server
channel:community
channel:direct
channel:owned
channel:press
channel:social
e2ee-constrained
gate:at-ga
gate:pre-ga
marketing
parity
relay:absent
relay:planned
relay:requested
relay:supported
risk:additive
risk:contract
risk:none
usability
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Nectenda/nectenda!181
No description provided.