Nectenda/nectenda
Watch
1
0
Fork
You've already forked nectenda
 0
Code Issues 1 Pull requests Projects 5 Releases Packages Wiki Activity Actions

Let a card bounced twice keep its label, instead of crashing the queue #154

Merged
nectenda-agent merged 1 commit from worktree-idempotent-labels into main 2026-09-24 17:29:41 +01:00
Conversation 0 Commits 1 Files changed 3 +44 -4
nectenda-agent commented 2026-09-24 16:51:40 +01:00
Collaborator
Copy link

Bouncing a card that already carried merge-conflict (NEC-52, bounced for the second time) got a 400 "label already exists", crashing the queue mid-bounce, before it saved state.

  • Vikunja.addLabel / removeLabel are idempotent for exactly those two responses; every other error still throws. Tested both ways, and mutation-checked.
  • bounce logs its reason before its side effects.

Changelog

NONE

Bouncing a card that already carried `merge-conflict` (NEC-52, bounced for the second time) got a 400 "label already exists", crashing the queue mid-bounce, before it saved state. - `Vikunja.addLabel` / `removeLabel` are idempotent for exactly those two responses; every other error still throws. Tested both ways, and mutation-checked. - `bounce` logs its reason before its side effects. ## Changelog NONE
Let a card bounced twice keep its label, instead of crashing the queue
Some checks failed
Release note / release-note (pull_request) Successful in 16s
Details
CI / promote (pull_request) Has been cancelled
Details
CI / e2e (pull_request) Has been cancelled
Details
CI / build (pull_request) Has been cancelled
Details
04b6d388e9 
The merge queue bounces a card by labelling it merge-conflict and moving
it to Ready. A card bounced once, reworked and handed back still carries
the label, since it only comes off on a merge. Bouncing it again asked
Vikunja to add a label the task already had, got a 400, and threw, in
the middle of the bounce and before the queue saved its state. The next
tick would have done the same: NEC-52, 24 Sep 2026, at the moment the
queue resumed after the NEC-15 revert.

- The Vikunja client's addLabel treats "already exists on the task" as
  success, and removeLabel treats a label that is not there as success.
  Every other error still throws; both directions are tested, and
  swallowing everything fails the test too.
- bounce logs its reason before its side effects, so a failure can no
  longer hide why a card was being bounced. That reason had to be read
  off the card this time.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015k9tkUtbU3wBpCHAHq7Qas
cruelacid force-pushed worktree-idempotent-labels from 04b6d388e9
Some checks failed
Release note / release-note (pull_request) Successful in 16s
Details
CI / promote (pull_request) Has been cancelled
Details
CI / e2e (pull_request) Has been cancelled
Details
CI / build (pull_request) Has been cancelled
Details
to d52e839ea9
All checks were successful
Release note / release-note (pull_request) Successful in 16s
Details
CI / build (pull_request) Successful in 5m0s
Details
CI / e2e (pull_request) Successful in 5m5s
Details
CI / promote (pull_request) Has been skipped
Details
CI / build (push) Successful in 4m43s
Details
CI / e2e (push) Successful in 4m49s
Details
CI / promote (push) Successful in 29s
Details
2026-09-24 16:52:07 +01:00 Compare
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
area:docs
docs/

  
area:identity
packages/identity

  
area:ops
deploy/, CI, hosting

  
area:plugin
packages/plugin

  
area:server
packages/server

  
channel:community
Obsidian forum, Obsidian Discord, Reddit

  
channel:direct
Cold outreach to named firms

  
channel:owned
nectenda.com pages, the feedback board

  
channel:press
Hacker News, newsletters, outlets, YouTube creators

  
channel:social
Bluesky, Mastodon, X, YouTube accounts

  
e2ee-constrained
End-to-end encryption changes the shape of the answer

  
gate:at-ga
Held until Gates A-C close and terms/privacy leave DRAFT

  
gate:pre-ga
Safe to do before the launch gates close

  
marketing
Reach and positioning; work published off nectenda.com

  
parity
Relay feature-parity programme

  
relay:absent
4 - Not supported, not requested, not planned at Relay

  
relay:planned
2 - On Relay's roadmap (Active/Planned) or has an open PR

  
relay:requested
3 - Asked for by Relay users or under 'Considering'; not committed

  
relay:supported
1 - Relay ships this today

  
risk:additive
New message type, table or column; backward compatible

  
risk:contract
Changes something existing accounts or stored data depend on

  
risk:none
Client-only; the server is untouched

  
usability
How the product is understood and learned, not what it does

No labels
area:docs
area:identity
area:ops
area:plugin
area:server
channel:community
channel:direct
channel:owned
channel:press
channel:social
e2ee-constrained
gate:at-ga
gate:pre-ga
marketing
parity
relay:absent
relay:planned
relay:requested
relay:supported
risk:additive
risk:contract
risk:none
usability
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Nectenda/nectenda!154
No description provided.