Make the pull request the unit of change, and refuse one with no release note #113

Merged

cruelacid merged 3 commits from worktree-release-note into main 2026-09-23 15:23:32 +01:00

Conversation 0 Commits 3 Files changed 8 +341 -7

cruelacid commented 2026-09-23 14:41:34 +01:00

Owner

Copy link

Closes #81. Part of #77.

• CLAUDE.md, "Working a plan": one plan → one worktree → one branch → one PR → fast-forward onto main. It covers what the body carries, the REST calls to open and merge (tea has no fast-forward-only style), and that the PR run and then the main run must both be watched.
• .forgejo/pull_request_template.md, with an empty ## Changelog block. An untouched template fails the check.
• scripts/lib/release-note.mjs (the parser) and scripts/release-note-check.mjs (the CLI). The block may be one sentence, bullets, or NONE. release-notes/<PR>.md wins when present.
• .forgejo/workflows/release-note.yml, a separate workflow on opened, edited, synchronize, reopened, so editing the body re-checks without re-running e2e.
• Tests run under pnpm lint (node --test 'scripts/*.test.mjs'). They are mutation-checked both ways: accepting an empty block fails 1 test, and refusing NONE fails 2.

The check becomes required in #79, together with build and e2e.

Changelog

NONE

🤖 Generated with Claude Code

https://claude.ai/code/session_01StURdiv33xnMfE2XRyg8Lt

Closes #81. Part of #77. - **CLAUDE.md**, "Working a plan": one plan → one worktree → one branch → one PR → fast-forward onto `main`. It covers what the body carries, the REST calls to open and merge (`tea` has no fast-forward-only style), and that the PR run and then the `main` run must both be watched. - **`.forgejo/pull_request_template.md`**, with an empty `## Changelog` block. An untouched template fails the check. - **`scripts/lib/release-note.mjs`** (the parser) and **`scripts/release-note-check.mjs`** (the CLI). The block may be one sentence, bullets, or `NONE`. `release-notes/<PR>.md` wins when present. - **`.forgejo/workflows/release-note.yml`**, a separate workflow on `opened, edited, synchronize, reopened`, so editing the body re-checks without re-running e2e. - **Tests** run under `pnpm lint` (`node --test 'scripts/*.test.mjs'`). They are mutation-checked both ways: accepting an empty block fails 1 test, and refusing `NONE` fails 2. The check becomes *required* in #79, together with `build` and `e2e`. ## Changelog NONE 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01StURdiv33xnMfE2XRyg8Lt

cruelacid added the

area:docs

label 2026-09-23 14:41:34 +01:00

cruelacid added 1 commit 2026-09-23 14:41:34 +01:00

Make the pull request the unit of change, and refuse one with no release note ... be7848e8c3

CLAUDE.md's "Working a plan" gains the step it was missing: one plan, one
worktree, one branch, one pull request, fast-forward onto main. It says what
the body must carry, how to open and merge one when tea cannot merge
fast-forward-only, and that the pull request's run is now where the gate is
watched, before the main run that promotes.

The release note is a "## Changelog" block in the body — one user-facing
sentence, or NONE — or release-notes/<PR>.md for several. A separate
workflow checks it on opened, edited, synchronize and reopened, so fixing a
missing note re-runs a node process rather than the whole suite. The
template ships the block empty, and an untouched template fails: a check
that passed on its own template would let the changelog omit a change
silently, which is the one thing it is for.

The parser's tests run under pnpm lint alongside the eslint rule's, since
scripts are not a workspace package and pnpm -r test never reaches them.
Both directions were mutation-checked: accepting an empty block, and
refusing NONE, each fail the suite.

Part of #77. Closes #81.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01StURdiv33xnMfE2XRyg8Lt

cruelacid added 1 commit 2026-09-23 14:42:14 +01:00

End a release note at any heading or rule, so Renovate's body cannot join it ... 4994d772b3

Renovate appends its own sections after the notes it is given: a rule, then
"### Release Notes" with the upstream changelog. A block that ran until the
next level-two heading read those as entries, and refused NONE for having
company. Mutation-checked: restoring the old stop rule fails two tests.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01StURdiv33xnMfE2XRyg8Lt

cruelacid force-pushed worktree-release-note from 4994d772b3 to 925b45afc2 2026-09-23 14:52:46 +01:00 Compare

cruelacid referenced this pull request from a commit 2026-09-23 15:14:09 +01:00

Record the e2e hang that failed pull request #113

cruelacid added 1 commit 2026-09-23 15:14:09 +01:00

Record the e2e hang that failed pull request #113 ... 31872acf50

repro-runaway.test.ts timed out at 300 s with the session already gone,
the same signature as run 468 in another file, on a pull request that
touched nothing under packages/. Written down, as the README asks, rather
than re-run past.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01StURdiv33xnMfE2XRyg8Lt

cruelacid merged commit 31872acf50 into main 2026-09-23 15:23:32 +01:00

cruelacid referenced this pull request 2026-09-23 15:24:31 +01:00

Merge Renovate development dependencies through a pull request #115

cruelacid referenced this pull request 2026-09-23 15:39:09 +01:00

Serialise CI at the workflow level, where Forgejo actually applies it #117

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

area:docs

docs/

  

area:identity

packages/identity

  

area:ops

deploy/, CI, hosting

  

area:plugin

packages/plugin

  

area:server

packages/server

  

channel:community

Obsidian forum, Obsidian Discord, Reddit

  

channel:direct

Cold outreach to named firms

  

channel:owned

nectenda.com pages, the feedback board

  

channel:press

Hacker News, newsletters, outlets, YouTube creators

  

channel:social

Bluesky, Mastodon, X, YouTube accounts

  

e2ee-constrained

End-to-end encryption changes the shape of the answer

  

gate:at-ga

Held until Gates A-C close and terms/privacy leave DRAFT

  

gate:pre-ga

Safe to do before the launch gates close

  

marketing

Reach and positioning; work published off nectenda.com

  

parity

Relay feature-parity programme

  

relay:absent

4 - Not supported, not requested, not planned at Relay

  

relay:planned

2 - On Relay's roadmap (Active/Planned) or has an open PR

  

relay:requested

3 - Asked for by Relay users or under 'Considering'; not committed

  

relay:supported

1 - Relay ships this today

  

risk:additive

New message type, table or column; backward compatible

  

risk:contract

Changes something existing accounts or stored data depend on

  

risk:none

Client-only; the server is untouched

  

usability

How the product is understood and learned, not what it does

No labels

area:docs

area:identity

area:ops

area:plugin

area:server

channel:community

channel:direct

channel:owned

channel:press

channel:social

e2ee-constrained

gate:at-ga

gate:pre-ga

marketing

parity

relay:absent

relay:planned

relay:requested

relay:supported

risk:additive

risk:contract

risk:none

usability

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

Nectenda/nectenda!113

No description provided.