Derive the GitHub release notes, and show them at the dry-run checkpoint #84
Labels
No labels
area:docs
area:identity
area:ops
area:plugin
area:server
channel:community
channel:direct
channel:owned
channel:press
channel:social
e2ee-constrained
gate:at-ga
gate:pre-ga
marketing
parity
relay:absent
relay:planned
relay:requested
relay:supported
risk:additive
risk:contract
risk:none
usability
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Nectenda/nectenda#84
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Part of #77. Needs the ledger (#82).
Why
Two things, and the second is the more surprising.
releaseNotes(tag, sourceSha)inscripts/publish-plugin.mjsis a fixedtemplate — install instructions,
sha256(main.js), the source sha. It shouldcarry the version's section from
docs/changelog-plugin.md.And the operator has never seen the notes before they are published.
releaseNotes()is an inline argument togh release create, so it is neverprinted. The dry-run exit is the only human checkpoint in the entire plugin
release, and it shows everything except the thing that becomes public and
permanent.
What to do
releaseNotes()takes the version's section from the ledger, generated ratherthan hand-written.
release actually shows what is about to be published.
sha256(main.js). The hash is howsomebody checks the artefact against the source, and the client is the trust
anchor — that must not be traded away for tidier notes.
Watch for
assertAuthorship()enforcescedric@nectenda.comacross all mirror history.Nothing here should touch it, but a change to the commit path can trip it.