Revert NEC-15's checkpoint writer until its stall is understood #152
No reviewers
Labels
No labels
area:docs
area:identity
area:ops
area:plugin
area:server
channel:community
channel:direct
channel:owned
channel:press
channel:social
e2ee-constrained
gate:at-ga
gate:pre-ga
marketing
parity
relay:absent
relay:planned
relay:requested
relay:supported
risk:additive
risk:contract
risk:none
usability
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Nectenda/nectenda!152
Loading…
Reference in a new issue
No description provided.
Delete branch "worktree-revert-nec-15"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Task: NEC-15 — https://projectron.nerchure.com/tasks/15
Reverts #145 (
206d1f6andb7e3271). #151 (the NEC-87 fix) landed on top of NEC-15 meanwhile and is independent of it; its only shared file is the generateddocs/v1/conformance.md. So the result is exactlycdda616plus #151. That was checked:git diff cdda616 HEADequalsgit diff b7e3271 b9366a9outside the generated file, and the conformance check passes.cdda616is the last main that passed CI in full, and it is what eu1 and accounts are running.Why. main's run on
b7e3271failed inbuild:checkpoints.test.ts› "past the compaction threshold, through the WebSocket path › keeps the earlier state recoverable" timed out at 5 s. It was a stall, not slowness: the server started at 15:05:51.19 and the test logged nothing more. The same commit passed on the PR's run, and 120 of 120 runs on the Mac under parallel load, so it is intermittent and unexplained. It stalls where the test drives the real threaded writer through a compaction, as production does, so it does not ship until someone has instrumented it.Nothing to migrate back. Promote was skipped on
b7e3271, and eu1 and accounts are oncdda616, so no production database ever carried #145's schema change.Changelog: #145's entry must be dropped at the next cut. #145 carried "The server now keeps earlier versions of each note when it compacts edit history, instead of discarding them." Users never received it, so this revert is NONE, but
scripts/changelog.mjshas no revert handling and would otherwise list #145.Changelog
NONE
1bd34ce05cb6b264de8e